This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [rfc] Print MI fullname even for non-existing files


On 17/12/2012 3:58 PM, Jan Kratochvil wrote:

> Currently this patch only changes from user point of view MI:
> (gdb) -file-list-exec-source-file
> 	^done,line="1",file="deleted.c",macro-info="0"
> ->
> 	^done,line="1",file="deleted.c",fullname="/path/to/deleted.c",macro-info="0"

Seems like a good change to me.

> Is there a serious reason why fullname was suppressed for non-existing files?

I added the fullname field in source.c, there was no good reason then
for dropping the field if we got NULL back except that (1) it matched
the behaviour in stack.c, and (2) if we got null back then I'd have just
left the field empty which didn't feel very useful.

> While it breaks MI compatibility in some way I find it an acceptable change.

I agree.

Thanks,
Andrew




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]