This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 5/8] Different notification from packets.

This is okay.

On 12/11/2012 06:40 AM, Yao Qi wrote:
> +   enough reason to return to the caller.  On return, *IS_NOTIF stores
> +   a boolean whether GDB reads a notification  or not from remote.

Spurious double-space --------------------------^^

I suggest:

   On return, *IS_NOTIF stores a boolean indicating whether GDB has read
   a notification or not from the remote.

Or my preferred:

   *IS_NOTIF is an output boolean that indicates whether *BUF holds
   a notification or a regular packet.

Thanks,
-- 
Pedro Alves
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]