This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add fseek to ui-file


>>>>> "Hui" == Hui Zhu <teawater@gmail.com> writes:

Hui> +static int
Hui> +null_file_fseek (struct ui_file *stream, long offset, int whence)
Hui> +{
Hui> +  return 0;
Hui> +}

Why does this return success rather than error?
It seems strange to report success when nothing actually happens.

Hui> +typedef int (ui_file_fseek_ftype) (struct ui_file * stream, long offset,
Hui> +				   int whence);

Extra space after "*".

Hui> +extern int ui_file_fseek (struct ui_file * file, long offset, int whence);

Here too.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]