This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch v5 02/12] cli, btrace: add btrace cli
> From: markus.t.metzger@intel.com
> Cc: markus.t.metzger@gmail.com, jan.kratochvil@redhat.com, palves@redhat.com, tromey@redhat.com, kettenis@gnu.org, Markus Metzger <markus.t.metzger@intel.com>
> Date: Fri, 7 Dec 2012 11:37:14 +0100
>
> From: Markus Metzger <markus.t.metzger@intel.com>
>
> Add branch trace commands:
Thanks. This will be documented at some point, yes?
> + add_cmd ("list", class_btrace, cmd_btrace_list, _("\
> +List branch trace blocks.\n\n\
> +Prints a list of all blocks for which branch trace is available.\n\
"Print", not "prints", to be compatible with "List".
> +With a /a modifier, addresses are included.\n\
> +With a /f modifier, the function name is included (if available).\n\
It is better to use active tense, not passive tense:
With a /a modifier, include addresses.
With a /f modifier, include function names (if available).
> +With a /l modifier, source lines are include (if available).\n\
^^^^^^^
A typo.
> +With a /t modifier, prints the total number of trace blocks and stops.\n\
^^^^^^
"print"
> +Without any modifier, behaves as if /fl were specified.\n\n\
By default, include function names and source lines.
And I have a question: how to turn off all the optional print-outs?
Is there a /no-f modifier or something?
> +Without arguments, the full list of blocks is listed.\n\
> +With a range (<start>[-<end>]) argument, lists all blocks in that range.\n"),
Again, use active tense, and "list" instead of "lists".
Thanks.