This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [patch v4 13/13] btrace, x86: restrict to Atom
- From: "Metzger, Markus T" <markus dot t dot metzger at intel dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, "markus dot t dot metzger at gmail dot com" <markus dot t dot metzger at gmail dot com>, "palves at redhat dot com" <palves at redhat dot com>, "tromey at redhat dot com" <tromey at redhat dot com>, "kettenis at gnu dot org" <kettenis at gnu dot org>
- Date: Thu, 6 Dec 2012 10:15:21 +0000
- Subject: RE: [patch v4 13/13] btrace, x86: restrict to Atom
- References: <1354013351-14791-1-git-send-email-markus.t.metzger@intel.com> <1354013351-14791-14-git-send-email-markus.t.metzger@intel.com> <20121127130500.GA22431@host2.jankratochvil.net> <A78C989F6D9628469189715575E55B2307B288F7@IRSMSX102.ger.corp.intel.com> <20121127142904.GA30650@host2.jankratochvil.net>
> -----Original Message-----
> From: Jan Kratochvil [mailto:jan.kratochvil@redhat.com]
> Sent: Tuesday, November 27, 2012 3:29 PM
> To: Metzger, Markus T
> Cc: gdb-patches@sourceware.org; markus.t.metzger@gmail.com; palves@redhat.com; tromey@redhat.com; kettenis@gnu.org
> Subject: Re: [patch v4 13/13] btrace, x86: restrict to Atom
>
> On Tue, 27 Nov 2012 15:03:48 +0100, Metzger, Markus T wrote:
> > > There is i386-nat.c for the common functions between these two files.
> >
> > Is it OK put Linux specific code into i386-nat.c?
>
> True it is not so clear, it would be OK as long as the linux_supports_btrace()
> call is moved out of it, as otherwise it just checks the CPU hardware feature.
>
> But as you use it also in gdbserver I see now it can be moved to
> common/linux-btrace.[ch] with appropriate #ifdef __i386__ and __x86_64__.
> common/ currently does not have any per-file arch/target configury like gdb/
> and gdbserver/ have, one day it will probably have it but not now.
Pedro seems OK with this, as well. It simplifies the patch a lot. Thanks for pointing this out.
Regards,
Markus.
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052