This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFC: remove partial_symtab::objfile


On 11/29/2012 06:01 AM, Tom Tromey wrote:
This is a necessary step for symbol table location independence; but I
see it as a general cleanup as well -- back-pointers are better avoided
when possible, and it saves some tiny amount of memory.

It is a cleanup to me. What is "symbol table location independence"? Do we have the description or discussion on it some where?


@@ -2050,13 +2045,13 @@ xcoff_start_psymtab (struct objfile *objfile,
     are the information for includes and dependencies.  */

  static struct partial_symtab *
-xcoff_end_psymtab (struct partial_symtab *pst, const char **include_list,
+xcoff_end_psymtab (struct objfile *objfile,
+		   struct partial_symtab *pst, const char **include_list,
  		   int num_includes, int capping_symbol_number,
  		   struct partial_symtab **dependency_list,
  		   int number_dependencies, int textlow_not_set)

Why write in this way? to reduce the length of patch? or some other reason?


@@ -2319,7 +2314,8 @@ scan_xcoff_symtab (struct objfile *objfile)
  			       each program csect, because their text
  			       sections need not be adjacent.  */
  			    xcoff_end_psymtab
-			      (pst, psymtab_include_list, includes_used,
+			      (objfile,
+			       pst, psymtab_include_list, includes_used,
  			       symnum_before, dependency_list,
  			       dependencies_used, textlow_not_set);

and here.


--
Yao (éå)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]