This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix mi "-var-create" regression

From: Luis Machado <lgustavo at codesourcery dot com>
To: Joel Brobecker <brobecker at adacore dot com>
Cc: Andreas Schwab <schwab at linux-m68k dot org>, Tom Tromey <tromey at redhat dot com>, gdb-patches at sourceware dot org
Date: Fri, 30 Nov 2012 00:13:22 -0200
Subject: Re: [PATCH] Fix mi "-var-create" regression
References: <5075D4FD.9050900@mentor.com> <20121014171805.GB3050@adacore.com> <507BFF97.2000900@codesourcery.com> <87y5j4ziof.fsf@fleche.redhat.com> <508DB53E.30507@codesourcery.com> <m2y5hkqiet.fsf@igel.home> <20121129210737.GM3581@adacore.com>
Reply-to: lgustavo at codesourcery dot com

On 11/29/2012 07:07 PM, Joel Brobecker wrote:

Expecting: ^(-var-create sp1 \* \$sp[
]+)?(\^done,name="sp1",numchild="0",value="0x[0-9A-Fa-f]+",type="void \*",has_more="0"[
]+[(]gdb[)]
[ ]*)
-var-create sp1 * $sp
^done,name="sp1",numchild="0",value="70368744167200",type="uint64_t",has_more="0"
(gdb)
FAIL: gdb.mi/mi-var-create-rtti.exp: -var-create sp1 * $sp


Ah yes, the type of $sp isn't guaranteed to be a "void *".
Seems obvious in retrospect, but easy to overlook. And easy to fix,
depending on what the testcase was really trying to do.

True. Is this m68k?

I'll have to find a register that is of type (void *) for all the architectures.

Luis

References:
- Re: [PATCH] Fix mi "-var-create" regression
  - From: Andreas Schwab
- Re: [PATCH] Fix mi "-var-create" regression
  - From: Joel Brobecker

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]