This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Add CTF support to GDB [2/4] Fix a bug of function dwarf_expr_frame_base
- From: Tom Tromey <tromey at redhat dot com>
- To: Hui Zhu <hui_zhu at mentor dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Thu, 29 Nov 2012 12:14:41 -0700
- Subject: Re: [PATCH] Add CTF support to GDB [2/4] Fix a bug of function dwarf_expr_frame_base
- References: <50AC322D.2030209@mentor.com>
>>>>> "Hui" == Hui Zhu <hui_zhu@mentor.com> writes:
Hui> 2012-11-20 Hui Zhu <hui_zhu@mentor.com>
Hui> * dwarf2loc.c (dwarf_expr_frame_base): Add check for the return
Hui> value of get_frame_block.
I think this is reasonable even without the rest of your patches.
One nit:
Hui> + if (bl == NULL)
Hui> + error (_("No symbol table info available.\n"));
I don't think this is a very clear error message.
I'm not sure what else to suggest though.
Also, no \n at the end of the error message.
Tom