[RFA] Remove AC_HEADER_STAT from configure.ac

["Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>]

  Hi Pedro,

  I tried to do the AC_HEADER_STAT removal patch...
> 
> When moving headers to common/, we need to ensure that whatever config.h
> HAVE_FOO symbols they are using are also produced by gdbserver's configure
> too.

   Didn't know about this... Seems like I underestimated 
the complexity.
 
> gdb_wait.h seems to depend on AC_CHECK_HEADERS checks for sys/wait.h and
> wait.h.  gdbserver's configure only checks the former.

  Would adding wait.h to the gdbserver configure be enough for this
problem?
 
> gdb_stat.h seems to depend on AC_HEADER_STAT for STAT_MACROS_BROKEN.
> gdbserver's configure doesn't call that macro.  But, according to
autoconf's
> manual:
> 
> > Macro: AC_HEADER_STAT
> >
> > If the macros S_ISDIR, S_ISREG, etc. defined in sys/stat.h do not work
> properly
> > (returning false positives), define STAT_MACROS_BROKEN. This is
> > the case on Tektronix UTekV, Amdahl UTS and Motorola System V/88.
> >
> > This macro is obsolescent, as no current systems have the bug. New
> > programs need not use this macro.
> 
> These old hosts are not relevant for GDB anymore (I found references to
> Motorola 88000 but support was removed on 6.0).  So we can just remove
> the AC_HEADER_STAT call from gdb's configure.ac, and remove the whole
> STAT_MACROS_BROKEN block from gdb_stat.h.  That would be done as a
separate
> patch (in a separate email thread).  I'd prefer that be done before the
> move, thus avoiding adding AC_HEADER_STAT to gdbserver.

  I tried... 
Here is the result.
  Should we add stat.h to the list of checked headers?
I didn't find any HAVE_STAT_H occurrence,
and thus assumed this was unnecessary.


Pierre Muller


PS: In the regenerated files,
I discovered that configure has a strange, apparently unrelated
change... Is this normal?




$ cvs diff -u -p configure
Index: configure
===================================================================
RCS file: /cvs/src/src/gdb/configure,v
retrieving revision 1.376
diff -u -p -r1.376 configure
--- configure   14 Nov 2012 19:16:03 -0000      1.376
+++ configure   15 Nov 2012 14:21:16 -0000
>>> Expected changes removed...
@@ -12712,7 +12670,7 @@ else

            # First check to see if --with-tcl was specified.
            case "${host}" in
-               *-*-cygwin*) platDir="win" ;;
+               *-*-cygwin*|*-*-mingw*) platDir="win" ;;
                *) platDir="unix" ;;
            esac
            if test x"${with_tclconfig}" != x ; then
@@ -12841,7 +12799,7 @@ else

            # then check for a private Tk library
            case "${host}" in
-               *-*-cygwin*) platDir="win" ;;
+               *-*-cygwin*|*-*-mingw*) platDir="win" ;;
                *) platDir="unix" ;;
            esac
            if test x"${ac_cv_c_tkconfig}" = x ; then



ChangeLog entry:


2012-11-15  Pierre Muller  <muller@sourceware.org>

        * configure.ac (AC_HEADER_STAT): Remove.
        * gdb_stat.h (STAT_MACROS_BROKEN): Remove macro use
        and corresponding code.
        * configure: Regenerate.
        * config.in: Regenerate.

Index: src/gdb/configure.ac
===================================================================
RCS file: /cvs/src/src/gdb/configure.ac,v
retrieving revision 1.187
diff -u -p -r1.187 configure.ac
--- src/gdb/configure.ac        14 Nov 2012 19:16:04 -0000      1.187
+++ src/gdb/configure.ac        15 Nov 2012 14:16:46 -0000
@@ -1072,7 +1072,6 @@ fi
 # ------------------------- #

 AC_HEADER_DIRENT
-AC_HEADER_STAT
 AC_HEADER_STDC
 # elf_hp.h is for HP/UX 64-bit shared library support.
 AC_CHECK_HEADERS([nlist.h machine/reg.h poll.h sys/poll.h proc_service.h \
Index: src/gdb/gdb_stat.h
===================================================================
RCS file: /cvs/src/src/gdb/gdb_stat.h,v
retrieving revision 1.10
diff -u -p -r1.10 gdb_stat.h
--- src/gdb/gdb_stat.h  4 Jan 2012 08:17:02 -0000       1.10
+++ src/gdb/gdb_stat.h  15 Nov 2012 14:16:46 -0000
@@ -22,19 +22,6 @@
 #include <sys/types.h>
 #include <sys/stat.h>

-#ifdef STAT_MACROS_BROKEN
-#undef S_ISBLK
-#undef S_ISCHR
-#undef S_ISDIR
-#undef S_ISREG
-#undef S_ISFIFO
-#undef S_ISLNK
-#undef S_ISSOCK
-#undef S_ISMPB
-#undef S_ISMPC
-#undef S_ISNWK
-#endif
-
 #if !defined(S_ISBLK) && defined(S_IFBLK)
 #define S_ISBLK(m) (((m) & S_IFMT) == S_IFBLK)
 #endif