This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Always include defs.h first.

From: Tom Tromey <tromey at redhat dot com>
To: Pedro Alves <palves at redhat dot com>
Cc: Doug Evans <dje at google dot com>, gdb-patches at sourceware dot org
Date: Thu, 08 Nov 2012 12:21:16 -0700
Subject: Re: [PATCH] Always include defs.h first.
References: <20121107201107.25258.47267.stgit@brno.lan> <CADPb22QMBu5e5Vrxzm6aehYNnD2cBbiacb_STeZPKa7i-rpGiQ@mail.gmail.com> <509BE290.4000104@redhat.com>

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> OTOH, IMO, defs.h is special.

Yes, it is.  I'm in favor of this patch.

A different approach globally might be preferable.  But, that is a
separate discussion.  Your patch simply brings the rest of gdb in line
with what I understood to be existing practice.  We've certainly asked
patch submitters to make this change before...

Please put it in.

Tom

References:
- [PATCH] Always include defs.h first.
  - From: Pedro Alves
- Re: [PATCH] Always include defs.h first.
  - From: Doug Evans
- Re: [PATCH] Always include defs.h first.
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]