This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [7.5] PATCH: PR backtrace/14646 [x32] backtrace doesn't work
- From: Joel Brobecker <brobecker at adacore dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GDB <gdb-patches at sourceware dot org>
- Date: Sat, 20 Oct 2012 18:56:36 -0700
- Subject: Re: [7.5] PATCH: PR backtrace/14646 [x32] backtrace doesn't work
- References: <20121020234741.GA3626@gmail.com>
> This patch backports the fix from trunk to 7.5 branch. Tested on
> Linux/x86-64 and Linux/x32. OK to install?
[...]
> PR backtrace/14646
> PR gdb/14647
> * i386-tdep.h (gdbarch_tdep): Remove sp_regnum_from_eax and
> pc_regnum_from_eax.
> * i386-tdep.c (i386_gdbarch_init): Don't use sp_regnum_from_eax
> nor pc_regnum_from_eax.
> * amd64-tdep.c (amd64_x32_init_abi): Don't set sp_regnum_from_eax
> nor pc_regnum_from_eax.
I'm sorry to say that I am not comfortable at all with this going
in the 7.5 branch. If Mark is super confident, then OK, but this is
touching sp/pc handling for all x86 and x86-64 targets. And I don't
think that the issue this patch is fixing is that critical.
--
Joel