This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Display full file path in MI style disassembly listing
- From: Tom Tromey <tromey at redhat dot com>
- To: "Andrew Burgess" <aburgess at broadcom dot com>
- Cc: "gdb-patches\ at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Wed, 17 Oct 2012 11:15:49 -0600
- Subject: Re: [PATCH] Display full file path in MI style disassembly listing
- References: <506DB4B8.5030001@broadcom.com>
>>>>> "Andrew" == Andrew Burgess <aburgess@broadcom.com> writes:
Andrew> + char *filename;
I think this could be const.
Andrew> +
Andrew> + filename = s->fullname;
Andrew> + if (filename == NULL)
Andrew> + {
Andrew> + filename = symtab_to_fullname (s);
Andrew> + if (filename == NULL)
Andrew> + filename = s->filename;
Andrew> + }
Andrew> +
Andrew> ui_out_field_int (uiout, "line", line);
Andrew> ui_out_text (uiout, "\tin ");
Andrew> - ui_out_field_string (uiout, "file", s->filename);
Andrew> + ui_out_field_string (uiout, "file", filename);
Andrew> ui_out_text (uiout, "\n");
It isn't obvious to me that this only applies to the MI case.
Can you explain that?
Tom