This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] add skip_shlib_tests guard to tests that require shared lib support
- From: Pedro Alves <palves at redhat dot com>
- To: Yufeng Zhang <Yufeng dot Zhang at arm dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Wed, 17 Oct 2012 16:17:58 +0100
- Subject: Re: [PATCH] add skip_shlib_tests guard to tests that require shared lib support
- References: <5077DB83.8060504@arm.com>
On 10/12/2012 09:57 AM, Yufeng Zhang wrote:
>
> +if {[skip_shlib_tests]} {
> + untested ctxobj.exp
> + return -1
> +}
See <http://sourceware.org/gdb/wiki/GDBTestcaseCookbook>.
"In untested calls, please spell out the reason the test ends up untested, instead
of just writing the test name, as with the latter we just end up with the test name
duplicated in the gdb.sum output. For example: "
But in these skip_ *cases, I think we can just be silent. The vast majority of
the skip_* calls in the testsuite agrees (e.g., seen
with 'grep -rn "skip_" -A 3 | grep untested').
IOW, this is OK with the untested calls removed.
Thanks.
--
Pedro Alves