This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[commit] Regression for gdb.base/stap-probe.exp (and some others) [Re: [patch] Have gdb_breakpoint call pass]
On Mon, 15 Oct 2012 20:49:59 +0200, Doug Evans wrote:
> I gather the issue is that the code is now treating { allow-pending }
> like " allow-pending ", and the test for "allow-pending" (no spaces)
> is now failing.
Surprisingly not, I do not find it too clear:
gdb_breakpoint "$function" { allow-pending }
->
args=<{ allow-pending }>
gdb_breakpoint "$function" {allow-pending}
->
args=<allow-pending>
> Given that gdb_breakpoint is a varargs function, and
> parameters like allow-pending are part of the varargs parameters, it
> seems wrong to pass allow-pending as a list itself (which the braces
> imply), so perhaps we should remove the braces altogether.
> i.e., s/{ allow-pending }/allow-pending/
Checked in that way.
Thanks,
Jan
http://sourceware.org/ml/gdb-cvs/2012-10/msg00056.html
--- src/gdb/testsuite/ChangeLog 2012/10/15 17:35:54 1.3414
+++ src/gdb/testsuite/ChangeLog 2012/10/15 19:11:56 1.3415
@@ -1,3 +1,11 @@
+2012-10-15 Jan Kratochvil <jan.kratochvil@redhat.com>
+ Doug Evans <dje@google.com>
+
+ Fix recent gdb_breakpoint regression.
+ * gdb.java/jmisc.exp: gdb_breakpoint for $function - remove curly
+ braces from the parameter.
+ * gdb.java/jprint.exp: Likewise.
+
2012-10-15 Doug Evans <dje@google.com>
* lib/gdb.exp (runto): Fix call to gdb_breakpoint.
--- src/gdb/testsuite/gdb.java/jmisc.exp 2012/06/22 16:44:15 1.25
+++ src/gdb/testsuite/gdb.java/jmisc.exp 2012/10/15 19:11:56 1.26
@@ -43,8 +43,8 @@
# signature.
runto_main
set function "${testfile}.main(java.lang.String\[\])"
- gdb_breakpoint "$function" { allow-pending }
- gdb_breakpoint "${function}void" { allow-pending }
+ gdb_breakpoint "$function" allow-pending
+ gdb_breakpoint "${function}void" allow-pending
gdb_continue_to_breakpoint $function
gdb_test_multiple "ptype jmisc" "ptype jmisc" {
--- src/gdb/testsuite/gdb.java/jprint.exp 2012/06/22 16:44:15 1.23
+++ src/gdb/testsuite/gdb.java/jprint.exp 2012/10/15 19:11:56 1.24
@@ -43,8 +43,8 @@
# signature.
runto_main
set function "${testfile}.main(java.lang.String\[\])"
- gdb_breakpoint "$function" { allow-pending }
- gdb_breakpoint "${function}void" { allow-pending }
+ gdb_breakpoint "$function" allow-pending
+ gdb_breakpoint "${function}void" allow-pending
gdb_continue_to_breakpoint $function
gdb_test "p jvclass.addprint(4,5,6)" " = 15" "unambiguous static call"