This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Remove unnecessary '#' from an assembly test file

From: Yao Qi <yao at codesourcery dot com>
To: Yufeng Zhang <Yufeng dot Zhang at arm dot com>
Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
Date: Fri, 12 Oct 2012 18:01:17 +0800
Subject: Re: [PATCH] Remove unnecessary '#' from an assembly test file
References: <507598B8.2070207@arm.com>

On 10/10/2012 11:48 PM, Yufeng Zhang wrote:

This patch removes a hash character from the end of a symbol in
gdb/testsuite/gdb.dwarf2/dw2-icc-opaque.S

While some assemblers (e.g. x86 gas) are tolerant of it, others (e.g.
arm gas) do complain about it.

IIUC, dw2-icc-opaque.S is generated by icc, and looks icc adds a trailing '#' at the end of symbol. The '#' is useless here, AFAICS.

On the other hand, tic6x gas complains about it as well. I vote to remove this '#' as well, but I am not the people to approve it.

--
Yao

References:
- [PATCH] Remove unnecessary '#' from an assembly test file
  - From: Yufeng Zhang

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]