This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Modify trace-status output to always output stop-notes.

From: Yao Qi <yao at codesourcery dot com>
To: Dmitry Kozlov <dmitry_kozlov at mentor dot com>
Cc: <gdb-patches at sourceware dot org>, "'Stan_Shebs at mentor dot com'" <Stan_Shebs at mentor dot com>, Vladimir Prus <vladimir at codesourcery dot com>
Date: Thu, 11 Oct 2012 08:10:47 +0800
Subject: Re: [PATCH] Modify trace-status output to always output stop-notes.
References: <50755958.5090107@mentor.com>

On 10/10/2012 07:17 PM, Dmitry Kozlov wrote:

+  if (ts->stop_desc)
+    {
+	  char *buf = (char *) xmalloc (strlen (ts->stop_desc) * 2 + 1);
+
+	  bin2hex ((gdb_byte *) ts->stop_desc, buf, 0);
+	  fprintf (fp, ";stop-notes:%s", buf);
+   }


Besides Stan's comments, the indentation here looks strange to me, and
BUF is not xfree'ed.

--
Yao

Follow-Ups:
- Re: [PATCH] Modify trace-status output to always output stop-notes.
  - From: Dmitry Kozlov

References:
- [PATCH] Modify trace-status output to always output stop-notes.
  - From: Dmitry Kozlov

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]