This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 0/4] bitpos expansion summary reloaded
- From: Siddhesh Poyarekar <siddhesh at redhat dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 1 Oct 2012 10:50:48 +0530
- Subject: Re: [PATCH 0/4] bitpos expansion summary reloaded
- References: <20120927190053.1e7de264@spoyarek> <20120929173938.GA2987@host2.jankratochvil.net> <20120929181141.GA4009@host2.jankratochvil.net> <20120930065211.GA21118@host2.jankratochvil.net>
On Sun, 30 Sep 2012 08:52:11 +0200, Jan wrote:
> Or gcc with -Wconversion:
> t.c: In function âmainâ:
> t.c:5:3: warning: conversion to âintâ from âlong intâ may alter its
> value [-Wconversion] t.c:6:24: warning: conversion to âintâ from
> âlong intâ may alter its value [-Wconversion]
This seems good. However, how about committing these patches if
they're correct and then doing a run with -Wconversion? The patches
are kinda unwieldy to maintain like this since it's quite painful
to review the entire thing repeatedly and edit changelogs, etc. Besides,
they should be safe for mainline since expansion of types should not
pose a regression risk. I volunteer to do this of course.
Regards,
Siddhesh