This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On 08/28/2012 05:00 AM, Vladimir Prus wrote:+ /* If non-null, the pointer to a flag indicates that this function is being + called. */ + int *called;
But in practice, this is pointer that points to notification that must be supressed when this command is running. So, at least the comment is misleading. And if some other code will want to check whether the current command is A, it would have to look at notification flags.
So, at the very least, this field should have a different name, I think.Vladimir, The field name is changed to 'suppress_notification' with some comments update. How about this one?
Thanks, Volodya
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |