Re: [RFC] New GDB Port CR16

[Yao Qi <yao at codesourcery dot com>]

Kaushik,
Thanks for the patch.  I didn't read your patch in details yet, but have 
some comments on patch submission at first.

On 08/27/2012 02:36 PM, Kaushik Phatak wrote:
> 2012-08-24 Kaushik Phatak<kaushik.phatak@kpitcummins.com>
>
> gdb/ChangeLog:
> 	* configure.tgt (cr16-*-elf): New target.
> 	* cr16-tdep.c: New file.
>
> sim/cr16/ChangeLog:
> 	* interp.c (sim_complete_command): New stub function.
> 	* cr16_sim.h : Add defines for TRAP handling
> 	* simops.c: Breakpoint handling code
>
> opcodes/ChangeLog:
> 	* cr16-dis.c (match_opcode): Remove static function
> 	declaration.
> 	(make_instruction): Likewise.

Changes under opcodes dir should be submitted to binutils@sourceware.org.


> diff -upN gdb_src.orig/configure ./gdb_src/configure
> --- gdb_src.orig/configure	2012-06-28 17:20:52.000000000 +0530
> +++ ./gdb_src/configure	2012-08-17 16:56:10.000000000 +0530
> @@ -3447,7 +3447,7 @@ case "${target}" in
>       noconfigdirs="$noconfigdirs target-libgloss gdb"
>       ;;
>     cr16-*-*)
> -    noconfigdirs="$noconfigdirs gdb"
> +    noconfigdirs="$noconfigdirs target-libgloss"
>       ;;
>     d10v-*-*)
>       noconfigdirs="$noconfigdirs target-libgloss"
> diff -upN gdb_src.orig/configure.ac ./gdb_src/configure.ac
> --- gdb_src.orig/configure.ac	2012-06-28 17:20:52.000000000 +0530
> +++ ./gdb_src/configure.ac	2012-08-17 16:56:17.000000000 +0530
> @@ -873,7 +873,7 @@ case "${target}" in
>       noconfigdirs="$noconfigdirs target-libgloss gdb"
>       ;;
>     cr16-*-*)
> -    noconfigdirs="$noconfigdirs gdb"
> +    noconfigdirs="$noconfigdirs target-libgloss"
>       ;;
>     d10v-*-*)
>       noconfigdirs="$noconfigdirs target-libgloss"

The changes for top-level configure stuff should be submitted to 
gcc-patches with changelog entry.  Get it approved, apply it to gcc repo 
once your gdb patch is approved, and finally merge this change from gcc 
to binutils/gdb.  This is what I did for adding new port tic6x last 
year, IIRC.

--
Yao