This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/4] new gdb_queue.h in common/.
On Fri, Aug 24, 2012 at 11:43 AM, <dje@google.com> wrote:
> Yao Qi writes:
> > Hi,
> > When writing the patches for 'general notification', I find queue is
> > used in many places, so I think we may need a general queue. This
> > queue not only have typical operations enqueue and dequeue, but also
> > has some have some operations like remove and remove_all.
Hi. Another thing that occurs to me is that there isn't anything
gdb-specific here.
We have vec.h and gdb_vecs.h.
So "Consistency is good." says we should have queue.h and gdb_queues.h.
[queue.h can be renamed if it collides with something, the point is
that gdb doesn't appear in the name, nor in any symbol defined by it]
Igdb_vecs.h is for very generic vectors, and we don't have any very
generic queues yet, but that's what I'd use gdb_queues.h for.
I think this is a good thing to have btw. :-)
[given that we can't use c++ ...]
> >
> > gdb/
> >
> > 2012-08-24 Yao Qi <yao@codesourcery.com>
> >
> > * common/gdb_queue.h: New.