This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/2] Remove pass in skip_unwinder_tests

On 08/23/2012 10:49 AM, Yao Qi wrote:

> As we discussed, proc skip_unwinder_tests should not generate any FAIL
> or PASS in test summary, so this patch is a follow-up to to remove
> 'pass', and replace gdb_test_multiple with send_gdb/gdb_expect.  With
> this patch applied, these PASS are disappeared in test result.

Do we really need to replace gdb_test_multiple with send_gdb/gdb_expect?
gdb_test_multiple will only issue fails in the internal errors cases.
I find it acceptable that see nothing most the time, and see a FAIL
when something goes really really wrong.  More acceptable than the
timeouts we likely get with send_gdb/gdb_expect in the same really
really wrong cases, that is.

-- 
Pedro Alves
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]