This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[RFA] Include GNUlib config.h
- From: Keith Seitz <keiths at redhat dot com>
- To: "gdb-patches at sourceware dot org ml" <gdb-patches at sourceware dot org>
- Date: Wed, 22 Aug 2012 11:42:58 -0700
- Subject: [RFA] Include GNUlib config.h
Hi,
I've been working on some bugs dealing with charset conversions when I
noticed the following regression from 7.4:
(gdb-7.4) p string
$1 = L"A¢B"
(gdb-7.5_or_HEAD) p string
$1 = L"AB"
A little bisecting yielded the following commit as the cause:
http://sourceware.org/ml/gdb-patches/2012-04/msg00646.html
If you grok that message, you'll notice that it mentions changes to
defs.h, gdbserver/server.h, and gdbserver/gdbreplay.c to include this
new file (*files* actually - one for gdb, one for gdbserver).
It appears that those files were never committed. [I *hate* it when that
happens. :-)]
Do we want to throw this on the 7.5 branch as well?
Keith
ChangeLog
2012-08-22 Keith Seitz <keiths@redhat.com>
* defs.h: Include build-gnulib/config.h
gdbserver/ChangeLog
2012-08-22 Keith Seitz <keiths@redhat.com>
* server.h: Include build-gnulib-gbserver/config.h.
* gdbreplay.c: Likewise.
Index: defs.h
===================================================================
RCS file: /cvs/src/src/gdb/defs.h,v
retrieving revision 1.322
diff -u -p -r1.322 defs.h
--- defs.h 22 Aug 2012 17:48:51 -0000 1.322
+++ defs.h 22 Aug 2012 18:35:14 -0000
@@ -27,6 +27,7 @@
#endif
#include "config.h" /* Generated by configure. */
+#include "build-gnulib/config.h"
#include <sys/types.h>
#include <stdio.h>
Index: gdbserver/server.h
===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/server.h,v
retrieving revision 1.98
diff -u -p -r1.98 server.h
--- gdbserver/server.h 27 Jul 2012 08:09:12 -0000 1.98
+++ gdbserver/server.h 22 Aug 2012 18:35:14 -0000
@@ -21,6 +21,7 @@
#define SERVER_H
#include "config.h"
+#include "build-gnulib-gdbserver/config.h"
#ifdef __MINGW32CE__
#include "wincecompat.h"
Index: gdbserver/gdbreplay.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/gdbreplay.c,v
retrieving revision 1.34
diff -u -p -r1.34 gdbreplay.c
--- gdbserver/gdbreplay.c 4 Jan 2012 08:17:23 -0000 1.34
+++ gdbserver/gdbreplay.c 22 Aug 2012 18:35:14 -0000
@@ -19,6 +19,8 @@
along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include "config.h"
+#include "build-gnulib-gdbserver/config.h"
+
#include <stdio.h>
#if HAVE_SYS_FILE_H
#include <sys/file.h>