This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] gdb: improve usage strings
On Sat, Aug 11, 2012 at 10:36 AM, Mike Frysinger <vapier@gentoo.org> wrote:
> On Saturday 11 August 2012 13:16:18 Eli Zaretskii wrote:
>> > From: Mike Frysinger <vapier@gentoo.org>
>> > Date: Sat, 11 Aug 2012 12:54:40 -0400
>> > c = add_com ("signal", class_run, signal_command, _("\
>> >
>> > -Continue program giving it signal specified by the argument.\n\
>> > -An argument of \"0\" means continue program without giving it a
>> > signal."));
>> > +Continue program by sending it the specified signal.\n\
>>
>> This "by sending it" is AFAIU inaccurate: we don't continue program
>> _by_ sending it the signal, we continue the program _and_ send it the
>> signal. I actually don't see anything wrong with the original
>> wording.
>
> ok, but your response shows what i was trying to fix:
> - adding "the" before "program"
> - changing "giving" to "sending"
> the "by" change was incidental
>
> so i'll change it to:
> Continue program and send it the specified signal.
fwiw, I'm not comfortable with that wording.
To the naive user it's not clear (IMO) that the program is resumed
with the specified signal, i.e., I can imagine the user wondering if
there's a gap between when the target is resumed and when the signal
is delivered.
Do we have a target where there can be a delay? (e.g, the figurative
equivalent of "continue &; kill SIGNAL)?
Given that, I like something along the lines of "Continue program by
sending it the specified signal."