This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: bitpos expansion patches summary
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Siddhesh Poyarekar <siddhesh at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 9 Aug 2012 00:43:12 +0200
- Subject: Re: bitpos expansion patches summary
- References: <20120805005350.150e5b74@spoyarek>
Hi Siddhesh,
I have found one problem. We miss the cases (there won't be too many) like:
ada-lang.c:2315
offset is LONGEST:
long new_offset = offset;
As on x86_64 LONGEST is #defined as 'long'. But on LLP64 (MS-Windows IA64)
http://en.wikipedia.org/wiki/64-bit#64-bit_data_models
'long' is 32-bit but LONGEST is (presumably) still 64-bit.
'long' should be changed to 'LONGEST' at ada-lang.c:2315.
It probably requires to run splint also in 32-bit mode (on GNU/Linux).
Thanks,
Jan