This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA, doc RFA] Implement $_memeq, $_streq, $_strlen


> Date: Wed, 8 Aug 2012 09:52:04 -0700
> Cc: gdb-patches@sourceware.org
> From: dje@google.com
> 
> In response to Jan's strstr comment, I added $_regex.

Here I have a couple of comments:

> +@item $_regex(@var{str}, @var{regex})
> +@vindex $_regex@r{, convenience function}
> +Returns one if the string @var{str} matches the regular expression
> +@var{regex}.  Otherwise it returns zero.
> +The syntax of the regular expression is that specified by @code{Python}'s
> +regular expression support.

I would suggest to say here that 'str' and 'regex' are both C strings,
as you say for $_strlen etc.  Otherwise, the reference to Python could
fool the reader into thinking they should be Python strings.

Btw, what is the technical reason we require Python for these
functions?

Finally, I think it's better to use @findex instead of @vindex
(since these are functions).  Sorry I missed that earlier.

Thanks.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]