Re: [PATCH 07/10] nto

[Yao Qi <yao at codesourcery dot com>]

On Tuesday, July 31, 2012 01:41:53 PM Tom Tromey wrote:
> >>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
> Yao> 2012-07-30  Yao Qi  <yao@codesourcery.com>
> Yao>    * nto-tdep.c (_initialize_nto_tdep;): Call add_setshow_zuinteger_cmd
> Yao>    instead of add_setshow_zinteger_cmd.
> Yao>    * nto-tdep.h (struct nto_target_ops): Add 'unsigned' to field
> Yao>    'internal_debugging'.
> 
> Is this setting even used anywhere?

No.

> What if we just remove it instead?

This new version removes 'nto_internal_debugging' and field
'internal_debugging'.  It also removes command 'nto-debug' registration along
with its document.  After this, _initialize_nto_tdep becomes empty, so remove
it.  We don't register any commands in nto-tdep.c, so don't have to include
cli/cli-decode.h and cli/cli-cmds.h anymore.

Rebuild GDB with --enable-targets=all.  This patch is obvious, and I'll commit
it.

-- 
Yao (éå)

gdb/doc:

2012-08-01  Yao Qi  <yao@codesourcery.com>

	* gdb.texinfo (Native): Remove node Neutrino.

gdb:

2012-08-01  Yao Qi  <yao@codesourcery.com>

	* nto-tdep.c: Don't include cli/cli-decode.h and
	cli/cli-cmds.h.
	(_initialize_nto_tdep): Remove.
	* nto-tdep.h (struct nto_target_ops) <internal_debugging>:
	Remove field.
	Remove macro nto_internal_debugging.
---
 gdb/doc/gdb.texinfo |   19 -------------------
 gdb/nto-tdep.c      |   21 ---------------------
 gdb/nto-tdep.h      |    5 -----
 3 files changed, 0 insertions(+), 45 deletions(-)

diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index a4503bf..38d4cfe 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -19239,25 +19239,6 @@ threads; you can then change the properties of individual threads with
 the non-default commands.
 @end table
 
-
-@node Neutrino
-@subsection QNX Neutrino
-@cindex QNX Neutrino
-
-@value{GDBN} provides the following commands specific to the QNX
-Neutrino target:
-
-@table @code
-@item set debug nto-debug
-@kindex set debug nto-debug
-When set to on, enables debugging messages specific to the QNX
-Neutrino support.
-
-@item show debug nto-debug
-@kindex show debug nto-debug
-Show the current state of QNX Neutrino messages.
-@end table
-
 @node Darwin
 @subsection Darwin
 @cindex Darwin
diff --git a/gdb/nto-tdep.c b/gdb/nto-tdep.c
index 5e0c910..fddd548 100644
--- a/gdb/nto-tdep.c
+++ b/gdb/nto-tdep.c
@@ -24,8 +24,6 @@
 #include "gdb_string.h"
 #include "nto-tdep.h"
 #include "top.h"
-#include "cli/cli-decode.h"
-#include "cli/cli-cmds.h"
 #include "inferior.h"
 #include "gdbarch.h"
 #include "bfd.h"
@@ -393,22 +391,3 @@ nto_initialize_signals (void)
   signal_pass_update (SIGPHOTON, 1);
 #endif
 }
-
-/* Provide a prototype to silence -Wmissing-prototypes.  */
-extern initialize_file_ftype _initialize_nto_tdep;
-
-void
-_initialize_nto_tdep (void)
-{
-  add_setshow_zinteger_cmd ("nto-debug", class_maintenance,
-			    &nto_internal_debugging, _("\
-Set QNX NTO internal debugging."), _("\
-Show QNX NTO internal debugging."), _("\
-When non-zero, nto specific debug info is\n\
-displayed. Different information is displayed\n\
-for different positive values."),
-			    NULL,
-			    NULL, /* FIXME: i18n: QNX NTO internal
-				     debugging is %s.  */
-			    &setdebuglist, &showdebuglist);
-}
diff --git a/gdb/nto-tdep.h b/gdb/nto-tdep.h
index f2c9c4e..18ee716 100644
--- a/gdb/nto-tdep.h
+++ b/gdb/nto-tdep.h
@@ -31,9 +31,6 @@
 
 struct nto_target_ops
 {
-/* For 'maintenance debug nto-debug' command.  */
-  int internal_debugging;
-
 /* The CPUINFO flags from the remote.  Currently used by
    i386 for fxsave but future proofing other hosts.
    This is initialized in procfs_attach or nto_start_remote
@@ -79,8 +76,6 @@ struct nto_target_ops
 
 extern struct nto_target_ops current_nto_target;
 
-#define nto_internal_debugging (current_nto_target.internal_debugging)
-
 #define nto_cpuinfo_flags (current_nto_target.cpuinfo_flags)
 
 #define nto_cpuinfo_valid (current_nto_target.cpuinfo_valid)
-- 
1.7.7.6