This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 08/10] microblaze

From: Yao Qi <yao at codesourcery dot com>
To: <gdb-patches at sourceware dot org>
Cc: Michael Eager <eager at eagerm dot com>
Date: Wed, 1 Aug 2012 14:42:54 +0800
Subject: Re: [PATCH 08/10] microblaze
References: <87vch52mag.fsf@fleche.redhat.com> <1343731841-20687-9-git-send-email-yao@codesourcery.com> <5017EF55.70007@eagerm.com>

On Tuesday, July 31, 2012 07:44:37 AM Michael Eager wrote:
> >     /* Debug this files internals.  */
> >
> > -  add_setshow_zinteger_cmd ("microblaze", class_maintenance,
> > -                         &microblaze_debug_flag, _("\
> > +  add_setshow_zuinteger_cmd ("microblaze", class_maintenance,
> > +                          &microblaze_debug_flag, _("\
> >
> >   Set microblaze debugging."), _("\
> >   Show microblaze debugging."), _("\
> >   When non-zero, microblaze specific debugging is enabled."),
> >
> > -                         NULL,
> > -                         NULL,
> > -                         &setdebuglist, &showdebuglist);
> > +                          NULL,
> > +                          NULL,
> > +                          &setdebuglist, &showdebuglist);
> >
> >   }
> 
> Why is this needed?

Because debug flag should be 'unsigned' and 'add_setshow_zinteger_cmd' has 
been a little bit abused in GDB.  This patch tries to fix it.

-- 
Yao (éå)

Follow-Ups:
- Re: [PATCH 08/10] microblaze
  - From: Michael Eager

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]