Re: [RFA 5/4 take 2] Improved linker-debugger interface

[Gary Benson <gbenson at redhat dot com>]

Tom Tromey wrote:
> >>>>> "Gary" == Gary Benson <gbenson@redhat.com> writes:
> Gary> +/* See comments in objfiles.h.  */
> Gary> +
> Gary> +void
> Gary> +inhibit_section_map_updates (void)
> Gary> +{
> Gary> +  get_objfile_pspace_data (current_program_space)->inhibit_updates = 1;
> Gary> +
> Gary> +}
> 
> Spurious blank line before the "}".
> 
> Gary> @@ -1820,6 +1820,18 @@ svr4_handle_solib_event (bpstat bs)
> [...]
> Gary> +  inhibit_section_map_updates ();
> [...]
> Gary> +  resume_section_map_updates ();
> 
> If there is any possibility of throwing an exception between these
> calls, then there should be a cleanup instead.
[snip]
> If there is no possibility, then this patch is ok.

I think it is possible, so I've changed it.

Attached is an updated patch with both these fixes.

Thanks,
Gary

-- 
http://gbenson.net/

Attachment: rtld-stap-7.patch
Description: Text document