This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patchv2] Write bpt at the ON_STACK bpt address

> Date: Fri, 27 Jul 2012 20:46:33 +0200
> From: Jan Kratochvil <>
> Cc: Joel Brobecker <>,,        "Maciej W. Rozycki" <>
> -breakpoint should be inserted.  May return @code{NULL} to indicate that
> -software breakpoints are not supported.
> +breakpoint should be inserted.  The program counter (@code{*@var{pcptr}}
> +is inferior PC register encoded on the input and it is a plain address on the
> +output.  Function may return @code{NULL} to indicate that software breakpoints
> +are not supported.

I suggest a slight rewording:

 On input, the program counter (@code{*@var{pcptr}} is the encoded
 inferior's PC register.  The function returns the PC's plain address
 in this argument, or @code{NULL} if software breakpoints are not

Does this catch the intent correctly?

> -the return address (@var{bp_addr}).
> +the return address (@var{bp_addr}, in inferior PC register encoding).

> -should be inserted, @var{real_pc} to the resume address when starting
> -the call sequence, and return the updated inner-most stack address.
> +should be inserted (in inferior PC register encoding), @var{real_pc} to the

> -reserved for that breakpoint, and @var{real_pc} set to @var{funaddr}.
> +reserved for that breakpoint (in inferior PC register encoding), and

OK with these changes.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]