This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/6] allow to suppress more mi notification

On Thursday, July 26, 2012 04:30:18 PM Pedro Alves wrote:
> > -extern int mi_suppress_breakpoint_notifications;
> > +
> > +extern int mi_suppress_notification[];
> >
> >  
> Quite frankly, I don't see how putting these in an array is better than
> a separate global for each.  The memory used is the same, and with separate
> globals, it's a little easier to debug from a top gdb (just print
> mi_suppress_<TAB> to see the list of possibilities, etc.)  Are you planning
> on doing something over the whole array, that is abstracted from the
> semantics of each element of the array?

The intention of this change is to avoid introducing more global variables to 
suppress different types of notification.  I plan to add more notifications 
here (for register change, memory change, trace experiment change, etc), and 
we need more suppress flags for them.  Array makes sense here.

AFAICS, I don't do something over the whole array.

Yao (éå)

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]