This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Re-evaluate floating varobj as part of varobj_invalidate.
- From: Tom Tromey <tromey at redhat dot com>
- To: "Andrew Burgess" <aburgess at broadcom dot com>
- Cc: "gdb-patches\ at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Wed, 25 Jul 2012 11:52:22 -0600
- Subject: Re: Re-evaluate floating varobj as part of varobj_invalidate.
- References: <501025E0.30708@broadcom.com>
>>>>> "Andrew" == Andrew Burgess <aburgess@broadcom.com> writes:
Andrew> I have a bug & patch, but no great way to reproduce the issue as
Andrew> it's a use of pointer after free issue,
I suspect the recent-ish change to use -lmcheck by default will cause us
to catch this bug in the test suite, at least on glibc-using systems.
Andrew> The patch below simply removes the special case for floating
Andrew> varobj objects from varobj_invalidate_iter, and causes them to
Andrew> be re-evaluated or marked as invalid.
Seems reasonable to me.
Andrew> 2012-07-25 Andrew Burgess <aburgess@broadcom.com>
Andrew> * varobj.c (varobj_invalidate_iter): All varobj must be marked as
Andrew> invalid or reevaluated to prevent prevent references to possibly
Andrew> delete'd type objects being left in the varobj.
Patch is ok.
Tom