This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 01/10] change gdb to refcount bfd everywhere
On Fri, 20 Jul 2012 18:37:26 +0200, Tom Tromey wrote:
> This changes allocate_objfile to acquire a reference to the BFD,
> rather than steal a reference. Then it changes all callers, direct or
> indirect, to follow.
map_vmap still steals a reference.
> I'm still undecided as to whether this patch is an improvement. I
> think it does fix a couple of obscure latent memory leaks.
I find the code the only way "how it should be" now.
> In practice, though, this means adding a bunch of cleanups, which tends to
> obscure the code.
This should be fixed with the transition to C++.
> Let me know what you think.
I can't speak for each patch individually but all the 3 patches together seem
right to me. Even solib_read_symbols looks as fixed now.
Thanks,
Jan