This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[RFA] Cleanup: consolidate "unknown thread id" errors


This is a trivial cleanup to do $SUBJECT. I'm not sure there's a whole lot to be said about it, other than this sort of thing bothers me, so I changed this while working on my explicit linespec patchset.


2012-07-17  Keith Seitz  <>

	* breakpoint.c (invalid_thread_id_error): New function.
	(find_condition_and_thread): Use invalid_thread_id_error.
	(watch_command_1): Likewise.
diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index 6b9faf3..1a27fe4 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -9231,6 +9231,14 @@ check_fast_tracepoint_sals (struct gdbarch *gdbarch,
+/* Issue an invalid thread ID error.  */
+invalid_thread_id_error (int id)
+  error (_("Unknown thread %d."), id);
 /* Given TOK, a string specification of condition and thread, as
    accepted by the 'break' command, extract the condition
    string and thread number and set *COND_STRING and *THREAD.
@@ -9284,7 +9292,7 @@ find_condition_and_thread (char *tok, CORE_ADDR pc,
 	  if (tok == tmptok)
 	    error (_("Junk after thread keyword."));
 	  if (!valid_thread_id (*thread))
-	    error (_("Unknown thread %d."), *thread);
+	    invalid_thread_id_error (*thread);
       else if (toklen >= 1 && strncmp (tok, "task", toklen) == 0)
@@ -10763,7 +10771,7 @@ watch_command_1 (char *arg, int accessflag, int from_tty,
 	      /* Check if the thread actually exists.  */
 	      if (!valid_thread_id (thread))
-		error (_("Unknown thread %d."), thread);
+		invalid_thread_id_error (thread);
 	  else if (toklen == 4 && !strncmp (tok, "mask", 4))

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]