This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Fix inconsistency in blockvector addrmap vs non-addrmap handling

On Thu, 12 Jul 2012 07:19:30 +0200, Doug Evans wrote:
> I was playing with a case of "pc 0x42 in read in psymtab, but not in
> symtab" case today.
> gdb has other problems that get in the way, but having more
> consistency between partial and full syms has to be a good thing.

Therefore considering it as an agreement/approval of the patch.

Therefore I will check it in tomorrow with no reply.

> [btw, seems kinda odd to have two addrmaps: one for psymtabs/index and
> one for fullsyms.  I wonder if there's an opportunity here.]
> Here's an updated version of your patch to match the current tree.
> 2012-07-11  Jan Kratochvil  <>
>             Doug Evans  <>
>         * buildsym.c (end_symtab_1): Split it to ...
>         (end_symtab_get_static_block): ... this ...
>         (end_symtab_from_static_block): ... and this function.
>         (end_symtab, end_expandable_symtab): Call them.
>         * buildsym.h (end_symtab_get_static_block)
>         (end_symtab_from_static_block): New declarations.
>         * dwarf2read.c (process_full_comp_unit): New variable static_block.
>         Set its valid CU ranges.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]