This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH]Add option "-at" to "maint agent" and "maint agent-eval"


On Thu, Jun 28, 2012 at 2:37 AM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> ">" == Hui Zhu <teawater@gmail.com> writes:
>
>>> 2012-06-24  Hui Zhu  <hui_zhu@mentor.com>
>>>      * ax-gdb.c (cli/cli-utils.h): New include.
>>>      (linespec.h): Ditto.
>>>      (agent_eval_command_one): New function.
>>>      (agent_command_1): Ditto.
>>>      (agent_command): Call function agent_command_1.
>>>      (agent_eval_command): Ditto.
>>>      (_initialize_ax_gdb): Change help for "maint agent"
>>>      and "maint agent-eval".
>
> This is also ok.  I think it may slightly abuse linespec parsing, but
> considering that it is a 'maint' command, I don't think it matters, as
> we are free to say "don't do that", or change it as needed.
>
>>> +      expr = parse_exp_1 (&exp, block_for_pc (pc), 0);
>
> You'll need a minor tweak to get it to compile, since I changed
> parse_exp_1 today.
>
> Tom

OK.  Thanks for your help.

Checked in.
http://sourceware.org/ml/gdb-cvs/2012-07/msg00037.html
http://sourceware.org/ml/gdb-cvs/2012-07/msg00038.html
http://sourceware.org/ml/gdb-cvs/2012-07/msg00039.html

Best,
Hui


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]