This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 06/16] configure: add check for perf_event header


>>>>> "Markus" == Metzger, Markus T <markus.t.metzger@intel.com> writes:

Markus> Thanks for your review!

>> > +AC_CHECK_HEADERS(linux/perf_event.h)

Jan> There is already existing big AC_CHECK_HEADERS block at line 1014.

Markus> This new check is right at the end of that block. They got expanded by
Markus> conditional include statements.

It is better to just put the new file into the big AC_CHECK_HEADERS
invocation, if possible, since that results in a smaller configure file.
Right now you have added a separate AC_CHECK_HEADERS invocation, but it
doesn't need to be separate.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]