This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 02/16] source: add flags to print_source_lines ()
- From: Tom Tromey <tromey at redhat dot com>
- To: "Metzger\, Markus T" <markus dot t dot metzger at intel dot com>
- Cc: Jan Kratochvil <jan dot kratochvil at redhat dot com>, "kettenis\ at gnu dot org" <kettenis at gnu dot org>, "gdb-patches\ at sourceware dot org" <gdb-patches at sourceware dot org>, "markus dot t dot metzger\ at gmail dot com" <markus dot t dot metzger at gmail dot com>
- Date: Fri, 22 Jun 2012 14:08:23 -0600
- Subject: Re: [PATCH 02/16] source: add flags to print_source_lines ()
- References: <1337772151-20265-1-git-send-email-markus.t.metzger@intel.com> <1337772151-20265-3-git-send-email-markus.t.metzger@intel.com> <20120530204106.GB20633@host2.jankratochvil.net> <A78C989F6D9628469189715575E55B2307A9F022@IRSMSX102.ger.corp.intel.com>
>>>>> "Markus" == Metzger, Markus T <markus.t.metzger@intel.com> writes:
Jan> Make it then 'enum print_source_lines_flags flags'.
Markus> Flags is intended as bit vector. The enum just gives names to
Markus> the individual bits.
In C it is ok to use the enum type the way that Jan suggests; and it
makes debugging a bit simpler since gdb will print the symbolic value.
gdb doesn't do this consistently (it doesn't do anything consistently
:-); but it is nice to do in new code.
Tom