This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH/python] notify memory changed.

From: Tom Tromey <tromey at redhat dot com>
To: Yao Qi <yao at codesourcery dot com>
Cc: <gdb-patches at sourceware dot org>, "Abid\, Hafiz" <Hafiz_Abid at mentor dot com>, Joel Brobecker <brobecker at adacore dot com>
Date: Fri, 22 Jun 2012 08:35:28 -0600
Subject: Re: [PATCH/python] notify memory changed.
References: <1340075728-24870-1-git-send-email-yao@codesourcery.com> <1375760.Ghu1pfDITS@qiyao.dyndns.org> <EB3B29AD43CA924DA27099BC8519237629A526@EU-MBX-03.mgc.mentorg.com> <2883062.LPF6KAsNoT@qiyao.dyndns.org>

>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

>> Do you think it will be useful to have parameters of
>> observer_notify_memory_changed in same order as write_memory. When I looked
>> at this code, I had to look at the function to make sure it was not a typo.

Yao> I am not sure.  Both 'write_memory' and 'observer_notify_memory_changed' 
Yao> exists here for some years, and I guess people get use to them.

It is fine if you want to change it.
I agree it would be clearer.

Tom

References:
- [PATCH/python] notify memory changed.
  - From: Yao Qi
- Re: [PATCH/python] notify memory changed.
  - From: Yao Qi
- RE: [PATCH/python] notify memory changed.
  - From: Abid, Hafiz
- Re: [PATCH/python] notify memory changed.
  - From: Yao Qi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]