This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH/python] notify memory changed.
On Tuesday 19 June 2012 08:13:44 Joel Brobecker wrote:
> > 2012-06-18 Yao Qi <yao@codesourcery.com>
> >
> >
> >
> > * python/py-inferior.c (infpy_write_memory): Invoke
> > observer_notify_memory_changed.
>
> Just wondering if it shouldn't be write_memory itself that should
> call observer_notify_memory_changed?
So far, observer_notify_memory_changed is called in two places, ada-
lang.c:ada_value_assign and valops.c:value_assign. Looks like they are all
about memory changes by user-requested operations. Change in this patch
belongs to this type (user-requested changes).
The rest of calls to write_memory are about gdb-requested changes to achieve
some functions, such as inferior call or displaced stepping. I didn't think
of carefully the usefulness of notifying observers for operations during inf-
call or displaced stepping.
--
Yao (éå)