This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Add global/static and symbol kind indicator to .gdb_index

> cc:
> Date: Tue, 19 Jun 2012 00:49:31 -0700 (PDT)
> From: (Doug Evans)
> This patch adds a global/static bit and a symbol kind indicator
> to CU values in .gdb_index.

Thanks.  I have a few comments about the documentation part:

> +If a symbol has multiple uses within a CU then there is one
> +CU index+attributes value for each different use.

I would lose the "different" part, it's redundant here.

> +@item 0
> +This value is reserved and not to be used.
"and should not be used"

> +@item 2
> +The symbol is a variable.
> +Enum values are also included.

Not sure what the last sentence means.  Value is not a symbol.  Do you
mean "the symbol is a name of a variable or of an enum"?

And, if my reading of the code is correct, we should mention constants

> +@item 4
> +The symbol is not covered by the other kinds.

I think this is better:

  Any other kind of symbol.

> +@item Bit 31
> +This bit is zero if the value is ``global'' and one if it is ``static''.

Do we really need the quotes here?

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]