This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[commit] [patch 1/2] Generalize call_site.parameter key ("code cleanup")
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Sun, 17 Jun 2012 21:51:05 +0200
- Subject: [commit] [patch 1/2] Generalize call_site.parameter key ("code cleanup")
- References: <20120614064857.GA13508@host2.jankratochvil.net>
On Thu, 14 Jun 2012 08:48:57 +0200, Jan Kratochvil wrote:
> gdb/
> 2012-06-14 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> Code cleanup: Generalize call_site.parameter key.
> * dwarf2expr.c (execute_stack_op) <DW_OP_GNU_entry_value>: Remove
> variable dwarf_reg. New variable kind_u. Update parameters to
> push_dwarf_reg_entry_value.
> (ctx_no_push_dwarf_reg_entry_value): Update parameters.
> * dwarf2expr.h (enum call_site_parameter_kind)
> (union call_site_parameter_u): Forward declarations.
> (struct dwarf_expr_context_funcs): Update parameters and their
> description for push_dwarf_reg_entry_value.
> (ctx_no_push_dwarf_reg_entry_value): Update parameters.
> * dwarf2loc.c (call_site_parameter_matches): New function.
> (dwarf_expr_reg_to_entry_parameter): Update parameters and their
> description. Use call_site_parameter_matches.
> (dwarf_expr_push_dwarf_reg_entry_value, value_of_dwarf_reg_entry):
> Update parameters and their description.
> (value_of_dwarf_block_entry): Remove variables dwarf_reg and fb_offset.
> New variable kind_u. Adjust the caller for updated parameters.
> (needs_dwarf_reg_entry_value): Update parameters.
> * dwarf2read.c (read_call_site_scope): New variable loc. Use it
> instead of attr. Update for the changed fields of struct
> call_site_parameter.
> * gdbtypes.h: Include dwarf2expr.h.
> (enum call_site_parameter_kind): New.
> (struct call_site.parameter): New field kind. Wrap dwarf_reg and
> fb_offset into new union u.
With Tom's review checked this in:
http://sourceware.org/ml/gdb-cvs/2012-06/msg00132.html
Thanks,
Jan