This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: build error for mn10300-elf sim with your recent commit
- From: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>
- To: gdb-patches at sourceware dot org
- Cc: vapier at gentoo dot org, palves at redhat dot com, brobecker at adacore dot com
- Date: Sun, 17 Jun 2012 20:57:38 +0200
- Subject: Re: build error for mn10300-elf sim with your recent commit
> From: Hans-Peter Nilsson <hp@axis.com>
> Date: Sat, 16 Jun 2012 07:09:27 +0200
> > From: Mike Frysinger <vapier@gentoo.org>
> > Date: Sat, 16 Jun 2012 06:55:49 +0200
>
> > i vote for deleting all sysdep.h inclusions where the port doesn't have a
> > local sysdep.h.
>
> Sounds right, except that in some cases (like for cris-desc.c)
> it's the (CGEN) generator templates files that need fixing.
But the failing one was all human-written code. Fixed thus,
committed. People, when you edit these things, please
test-build the affected simulators. It doesn't catch the
weirdest host cases, but it does catch most breakages.
sim/mn10300:
* interp.c: Include config.h first. Do not include sysdep.h.
Index: interp.c
===================================================================
RCS file: /cvs/src/src/sim/mn10300/interp.c,v
retrieving revision 1.8
diff -p -u -r1.8 interp.c
--- interp.c 16 Feb 2012 23:17:27 -0000 1.8
+++ interp.c 17 Jun 2012 18:55:44 -0000
@@ -1,10 +1,10 @@
+#include "config.h"
#include <signal.h>
#include "sim-main.h"
#include "sim-options.h"
#include "sim-hw.h"
-#include "sysdep.h"
#include "bfd.h"
#include "sim-assert.h"
brgds, H-P