Re: [PATCH] arm-syscall record support [phase-3]

[oza Pawandeep <oza dot pawandeep at gmail dot com>]

Anybody would like to have review comments ? Or I can check it in ?

On Wed, Jun 13, 2012 at 9:26 AM, oza Pawandeep <oza.pawandeep@gmail.com> wrote:
> Gentle reminder to send review comments if any; although patch is
> straightforward.
> most of the things are borrowed from linux kernel source and x86 record things.
> ok to check in ?
>
> Regards,
> Oza.
>
> On Fri, Jun 8, 2012 at 6:12 PM, oza Pawandeep <oza.pawandeep@gmail.com> wrote:
>> Hi,
>>
>> This patch provides arm-syscall record support. currently it supports
>> till gdb_sys_sched_getaffinity = 242.
>>
>> TODO :
>> signal recording
>> IPC recording
>> create arm specific xml syscall; ? [dont know about x86, as need to
>> use xml there as well which is currently using enumrated values]
>>
>>
>> PATCH starts
>> -----------------------------------------------------
>> diff -urN orig/arm-linux-tdep.c new/arm-linux-tdep.c
>> --- orig/arm-linux-tdep.c ? ? ? 2012-04-28 02:17:52.000000000 +0530
>> +++ new/arm-linux-tdep.c ? ? ? ?2012-06-08 17:55:28.541657600 +0530
>> @@ -43,6 +43,9 @@
>> ?#include "gdbthread.h"
>> ?#include "symfile.h"
>>
>> +#include "record.h"
>> +#include "linux-record.h"
>> +
>> ?#include "cli/cli-utils.h"
>> ?#include "stap-probe.h"
>> ?#include "parser-defs.h"
>> @@ -1178,6 +1181,141 @@
>> ? return 1;
>> ?}
>>
>> +/* Record-Replay constructs; syscall, signal etc. ?*/
>> +
>> +#define ARM_R0_REGNUM ARM_A1_REGNUM
>> +#define ARM_R1_REGNUM ARM_R0_REGNUM + 1
>> +#define ARM_R2_REGNUM ARM_R1_REGNUM + 1
>> +#define ARM_R3_REGNUM ARM_R2_REGNUM + 1
>> +#define ARM_R4_REGNUM ARM_R3_REGNUM + 1
>> +#define ARM_R5_REGNUM ARM_R4_REGNUM + 1
>> +#define ARM_R6_REGNUM ARM_R5_REGNUM + 1
>> +#define ARM_R7_REGNUM ARM_R6_REGNUM + 1
>> +#define ARM_R8_REGNUM ARM_R7_REGNUM + 1
>> +#define ARM_R9_REGNUM ARM_R8_REGNUM + 1
>> +#define ARM_R10_REGNUM ARM_R9_REGNUM + 1
>> +#define ARM_R11_REGNUM ARM_R10_REGNUM + 1
>> +#define ARM_R12_REGNUM ARM_R11_REGNUM + 1
>> +#define ARM_R13_REGNUM ARM_R12_REGNUM + 1
>> +#define ARM_R14_REGNUM ARM_R13_REGNUM + 1
>> +
>> +struct linux_record_tdep arm_linux_record_tdep;
>> +
>> +static enum gdb_syscall
>> +arm_canonicalize_syscall (int syscall)
>> +{
>> + ?enum { sys_process_vm_writev = 377 };
>> +
>> + ?if (syscall <= sys_process_vm_writev)
>> + ? ?{
>> + ? ? ?if (syscall <= gdb_sys_sched_getaffinity)
>> + ? ? ? ?return syscall;
>> + ? ?}
>> +
>> + ?return -1;
>> +}
>> +
>> +
>> +static int
>> +arm_all_but_pc_registers_record (struct regcache *regcache)
>> +{
>> + ?if (record_arch_list_add_reg (regcache, ARM_R0_REGNUM))
>> + ? ?return -1;
>> + ?if (record_arch_list_add_reg (regcache, ARM_R1_REGNUM))
>> + ? ?return -1;
>> + ?if (record_arch_list_add_reg (regcache, ARM_R2_REGNUM))
>> + ? ?return -1;
>> + ?if (record_arch_list_add_reg (regcache, ARM_R3_REGNUM))
>> + ? ?return -1;
>> + ?if (record_arch_list_add_reg (regcache, ARM_R4_REGNUM))
>> + ? ?return -1;
>> + ?if (record_arch_list_add_reg (regcache, ARM_R5_REGNUM))
>> + ? ?return -1;
>> + ?if (record_arch_list_add_reg (regcache, ARM_R6_REGNUM))
>> + ? ?return -1;
>> + ?if (record_arch_list_add_reg (regcache, ARM_R7_REGNUM))
>> + ? ?return -1;
>> + ?if (record_arch_list_add_reg (regcache, ARM_R8_REGNUM))
>> + ? ?return -1;
>> + ?if (record_arch_list_add_reg (regcache, ARM_R9_REGNUM))
>> + ? ?return -1;
>> + ?if (record_arch_list_add_reg (regcache, ARM_R10_REGNUM))
>> + ? ?return -1;
>> + ?if (record_arch_list_add_reg (regcache, ARM_R11_REGNUM))
>> + ? ?return -1;
>> + ?if (record_arch_list_add_reg (regcache, ARM_R12_REGNUM))
>> + ? ?return -1;
>> + ?if (record_arch_list_add_reg (regcache, ARM_R13_REGNUM))
>> + ? ?return -1;
>> + ?if (record_arch_list_add_reg (regcache, ARM_R14_REGNUM))
>> + ? ?return -1;
>> + ?if (record_arch_list_add_reg (regcache, ARM_PS_REGNUM))
>> + ? ?return -1;
>> +
>> + ?return 0;
>> +}
>> +
>> +/* Record the system call.
>> + ? Record Change in followign registers.
>> + ? ARM_LR_REGNUM >> next insn to be executed
>> + ? ARM_SP_REGNUM
>> + ? SPSR << CPSR
>> + ? CPSR
>> + ? ARM_R0_REGNUM >> syscall number
>> + ? ARM_R1_REGNUM >> arg1
>> + ? ARM_R2_REGNUM >> arg2
>> + ? ARM_R3_REGNUM >> arg3
>> + ? ARM_R4_REGNUM >> arg4. ?*/
>> +
>> +static int
>> +arm_linux_swi_syscall_record (struct regcache *regcache)
>> +{
>> + ?int ret;
>> + ?LONGEST syscall_native;
>> + ?enum gdb_syscall syscall_gdb;
>> +
>> + ?regcache_raw_read_signed (regcache, ARM_R0_REGNUM, &syscall_native);
>> +
>> + ?syscall_gdb = arm_canonicalize_syscall (syscall_native);
>> +
>> + ?if (syscall_gdb < 0)
>> + ? ?{
>> + ? ? ?printf_unfiltered (_("Process record and replay target doesn't "
>> + ? ? ? ? ? ? ? ? ? ? ? ? ? "support syscall number %s\n"),
>> + ? ? ? ? ? ? ? ? ? ? ? ?plongest (syscall_native));
>> + ? ? ?return -1;
>> + ? ?}
>> +
>> + ?if (syscall_gdb == gdb_sys_sigreturn
>> + ? ? ?|| syscall_gdb == gdb_sys_rt_sigreturn)
>> + ? {
>> + ? ? if (arm_all_but_pc_registers_record (regcache))
>> + ? ? ? return -1;
>> + ? ? return 0;
>> + ? }
>> +
>> + ?ret = record_linux_system_call (syscall_gdb, regcache,
>> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?&arm_linux_record_tdep);
>> + ?if (ret)
>> + ? ?return ret;
>> +
>> + ?/* Record the return value of the system call. ?*/
>> + ?if (record_arch_list_add_reg (regcache, ARM_R0_REGNUM))
>> + ? ?return -1;
>> + ?/* Record LR. ?*/
>> + ?if (record_arch_list_add_reg (regcache, ARM_LR_REGNUM))
>> + ? ?return -1;
>> + ?/* Record CPSR. ?*/
>> + ?if (record_arch_list_add_reg (regcache, ARM_PS_REGNUM))
>> + ? ?return -1;
>> +
>> + ?return 0;
>> +}
>> +
>> +
>> ?static void
>> ?arm_linux_init_abi (struct gdbarch_info info,
>> ? ? ? ? ? ? ? ? ? ?struct gdbarch *gdbarch)
>> @@ -1293,7 +1431,166 @@
>> ? tdep->syscall_next_pc = arm_linux_syscall_next_pc;
>>
>> ? /* Syscall record. ?*/
>> - ?tdep->arm_swi_record = NULL;
>> + ?tdep->arm_swi_record = arm_linux_swi_syscall_record;
>> +
>> +
>> + ?/* Initialize the arm_linux_record_tdep. ?*/
>> + ?/* These values are the size of the type that will be used in a system
>> + ? ? call. ?They are obtained from Linux Kernel source. ?*/
>> + ?arm_linux_record_tdep.size_pointer
>> + ? ?= gdbarch_ptr_bit (gdbarch) / TARGET_CHAR_BIT;
>> + ?arm_linux_record_tdep.size__old_kernel_stat = 32;
>> + ?arm_linux_record_tdep.size_tms = 16;
>> + ?arm_linux_record_tdep.size_loff_t = 8;
>> + ?arm_linux_record_tdep.size_flock = 16;
>> + ?arm_linux_record_tdep.size_oldold_utsname = 45;
>> + ?arm_linux_record_tdep.size_ustat = 20;
>> + ?arm_linux_record_tdep.size_old_sigaction = 140;
>> + ?arm_linux_record_tdep.size_old_sigset_t = 128;
>> + ?arm_linux_record_tdep.size_rlimit = 8;
>> + ?arm_linux_record_tdep.size_rusage = 72;
>> + ?arm_linux_record_tdep.size_timeval = 8;
>> + ?arm_linux_record_tdep.size_timezone = 8;
>> + ?arm_linux_record_tdep.size_old_gid_t = 2;
>> + ?arm_linux_record_tdep.size_old_uid_t = 2;
>> + ?arm_linux_record_tdep.size_fd_set = 128;
>> + ?arm_linux_record_tdep.size_dirent = 268;
>> + ?arm_linux_record_tdep.size_dirent64 = 276;
>> + ?arm_linux_record_tdep.size_statfs = 64;
>> + ?arm_linux_record_tdep.size_statfs64 = 84;
>> + ?arm_linux_record_tdep.size_sockaddr = 16;
>> + ?arm_linux_record_tdep.size_int
>> + ? ?= gdbarch_int_bit (gdbarch) / TARGET_CHAR_BIT;
>> + ?arm_linux_record_tdep.size_long
>> + ? ?= gdbarch_long_bit (gdbarch) / TARGET_CHAR_BIT;
>> + ?arm_linux_record_tdep.size_ulong
>> + ? ?= gdbarch_long_bit (gdbarch) / TARGET_CHAR_BIT;
>> + ?arm_linux_record_tdep.size_msghdr = 28;
>> + ?arm_linux_record_tdep.size_itimerval = 16;
>> + ?arm_linux_record_tdep.size_stat = 88;
>> + ?arm_linux_record_tdep.size_old_utsname = 325;
>> + ?arm_linux_record_tdep.size_sysinfo = 64;
>> + ?arm_linux_record_tdep.size_msqid_ds = 88;
>> + ?arm_linux_record_tdep.size_shmid_ds = 84;
>> + ?arm_linux_record_tdep.size_new_utsname = 390;
>> + ?arm_linux_record_tdep.size_timex = 128;
>> + ?arm_linux_record_tdep.size_mem_dqinfo = 24;
>> + ?arm_linux_record_tdep.size_if_dqblk = 68;
>> + ?arm_linux_record_tdep.size_fs_quota_stat = 68;
>> + ?arm_linux_record_tdep.size_timespec = 8;
>> + ?arm_linux_record_tdep.size_pollfd = 8;
>> + ?arm_linux_record_tdep.size_NFS_FHSIZE = 32;
>> + ?arm_linux_record_tdep.size_knfsd_fh = 132;
>> + ?arm_linux_record_tdep.size_TASK_COMM_LEN = 16;
>> + ?arm_linux_record_tdep.size_sigaction = 140;
>> + ?arm_linux_record_tdep.size_sigset_t = 8;
>> + ?arm_linux_record_tdep.size_siginfo_t = 128;
>> + ?arm_linux_record_tdep.size_cap_user_data_t = 12;
>> + ?arm_linux_record_tdep.size_stack_t = 12;
>> + ?arm_linux_record_tdep.size_off_t = arm_linux_record_tdep.size_long;
>> + ?arm_linux_record_tdep.size_stat64 = 96;
>> + ?arm_linux_record_tdep.size_gid_t = 2;
>> + ?arm_linux_record_tdep.size_uid_t = 2;
>> + ?arm_linux_record_tdep.size_PAGE_SIZE = 4096;
>> + ?arm_linux_record_tdep.size_flock64 = 24;
>> + ?arm_linux_record_tdep.size_user_desc = 16;
>> + ?arm_linux_record_tdep.size_io_event = 32;
>> + ?arm_linux_record_tdep.size_iocb = 64;
>> + ?arm_linux_record_tdep.size_epoll_event = 12;
>> + ?arm_linux_record_tdep.size_itimerspec
>> + ? ?= arm_linux_record_tdep.size_timespec * 2;
>> + ?arm_linux_record_tdep.size_mq_attr = 32;
>> + ?arm_linux_record_tdep.size_siginfo = 128;
>> + ?arm_linux_record_tdep.size_termios = 36;
>> + ?arm_linux_record_tdep.size_termios2 = 44;
>> + ?arm_linux_record_tdep.size_pid_t = 4;
>> + ?arm_linux_record_tdep.size_winsize = 8;
>> + ?arm_linux_record_tdep.size_serial_struct = 60;
>> + ?arm_linux_record_tdep.size_serial_icounter_struct = 80;
>> + ?arm_linux_record_tdep.size_hayes_esp_config = 12;
>> + ?arm_linux_record_tdep.size_size_t = 4;
>> + ?arm_linux_record_tdep.size_iovec = 8;
>> +
>> +
>> + ?/* These values are the second argument of system call "sys_ioctl".
>> + ? ? ?They are obtained from Linux Kernel source. ?*/
>> + ? arm_linux_record_tdep.ioctl_TCGETS = 0x5401;
>> + ? arm_linux_record_tdep.ioctl_TCSETS = 0x5402;
>> + ? arm_linux_record_tdep.ioctl_TCSETSW = 0x5403;
>> + ? arm_linux_record_tdep.ioctl_TCSETSF = 0x5404;
>> + ? arm_linux_record_tdep.ioctl_TCGETA = 0x5405;
>> + ? arm_linux_record_tdep.ioctl_TCSETA = 0x5406;
>> + ? arm_linux_record_tdep.ioctl_TCSETAW = 0x5407;
>> + ? arm_linux_record_tdep.ioctl_TCSETAF = 0x5408;
>> + ? arm_linux_record_tdep.ioctl_TCSBRK = 0x5409;
>> + ? arm_linux_record_tdep.ioctl_TCXONC = 0x540A;
>> + ? arm_linux_record_tdep.ioctl_TCFLSH = 0x540B;
>> + ? arm_linux_record_tdep.ioctl_TIOCEXCL = 0x540C;
>> + ? arm_linux_record_tdep.ioctl_TIOCNXCL = 0x540D;
>> + ? arm_linux_record_tdep.ioctl_TIOCSCTTY = 0x540E;
>> + ? arm_linux_record_tdep.ioctl_TIOCGPGRP = 0x540F;
>> + ? arm_linux_record_tdep.ioctl_TIOCSPGRP = 0x5410;
>> + ? arm_linux_record_tdep.ioctl_TIOCOUTQ = 0x5411;
>> + ? arm_linux_record_tdep.ioctl_TIOCSTI = 0x5412;
>> + ? arm_linux_record_tdep.ioctl_TIOCGWINSZ = 0x5413;
>> + ? arm_linux_record_tdep.ioctl_TIOCSWINSZ = 0x5414;
>> + ? arm_linux_record_tdep.ioctl_TIOCMGET = 0x5415;
>> + ? arm_linux_record_tdep.ioctl_TIOCMBIS = 0x5416;
>> + ? arm_linux_record_tdep.ioctl_TIOCMBIC = 0x5417;
>> + ? arm_linux_record_tdep.ioctl_TIOCMSET = 0x5418;
>> + ? arm_linux_record_tdep.ioctl_TIOCGSOFTCAR = 0x5419;
>> + ? arm_linux_record_tdep.ioctl_TIOCSSOFTCAR = 0x541A;
>> + ? arm_linux_record_tdep.ioctl_FIONREAD = 0x541B;
>> + ? arm_linux_record_tdep.ioctl_TIOCINQ = arm_linux_record_tdep.ioctl_FIONREAD;
>> + ? arm_linux_record_tdep.ioctl_TIOCLINUX = 0x541C;
>> + ? arm_linux_record_tdep.ioctl_TIOCCONS = 0x541D;
>> + ? arm_linux_record_tdep.ioctl_TIOCGSERIAL = 0x541E;
>> + ? arm_linux_record_tdep.ioctl_TIOCSSERIAL = 0x541F;
>> + ? arm_linux_record_tdep.ioctl_TIOCPKT = 0x5420;
>> + ? arm_linux_record_tdep.ioctl_FIONBIO = 0x5421;
>> + ? arm_linux_record_tdep.ioctl_TIOCNOTTY = 0x5422;
>> + ? arm_linux_record_tdep.ioctl_TIOCSETD = 0x5423;
>> + ? arm_linux_record_tdep.ioctl_TIOCGETD = 0x5424;
>> + ? arm_linux_record_tdep.ioctl_TCSBRKP = 0x5425;
>> + ? arm_linux_record_tdep.ioctl_TIOCTTYGSTRUCT = 0x5426;
>> + ? arm_linux_record_tdep.ioctl_TIOCSBRK = 0x5427;
>> + ? arm_linux_record_tdep.ioctl_TIOCCBRK = 0x5428;
>> + ? arm_linux_record_tdep.ioctl_TIOCGSID = 0x5429;
>> + ? arm_linux_record_tdep.ioctl_TCGETS2 = 0x802c542a;
>> + ? arm_linux_record_tdep.ioctl_TCSETS2 = 0x402c542b;
>> + ? arm_linux_record_tdep.ioctl_TCSETSW2 = 0x402c542c;
>> + ? arm_linux_record_tdep.ioctl_TCSETSF2 = 0x402c542d;
>> + ? arm_linux_record_tdep.ioctl_TIOCGPTN = 0x80045430;
>> + ? arm_linux_record_tdep.ioctl_TIOCSPTLCK = 0x40045431;
>> + ? arm_linux_record_tdep.ioctl_FIONCLEX = 0x5450;
>> + ? arm_linux_record_tdep.ioctl_FIOCLEX = 0x5451;
>> + ? arm_linux_record_tdep.ioctl_FIOASYNC = 0x5452;
>> + ? arm_linux_record_tdep.ioctl_TIOCSERCONFIG = 0x5453;
>> + ? arm_linux_record_tdep.ioctl_TIOCSERGWILD = 0x5454;
>> + ? arm_linux_record_tdep.ioctl_TIOCSERSWILD = 0x5455;
>> + ? arm_linux_record_tdep.ioctl_TIOCGLCKTRMIOS = 0x5456;
>> + ? arm_linux_record_tdep.ioctl_TIOCSLCKTRMIOS = 0x5457;
>> + ? arm_linux_record_tdep.ioctl_TIOCSERGSTRUCT = 0x5458;
>> + ? arm_linux_record_tdep.ioctl_TIOCSERGETLSR = 0x5459;
>> + ? arm_linux_record_tdep.ioctl_TIOCSERGETMULTI = 0x545A;
>> + ? arm_linux_record_tdep.ioctl_TIOCSERSETMULTI = 0x545B;
>> + ? arm_linux_record_tdep.ioctl_TIOCMIWAIT = 0x545C;
>> + ? arm_linux_record_tdep.ioctl_TIOCGICOUNT = 0x545D;
>> + ? arm_linux_record_tdep.ioctl_TIOCGHAYESESP = 0x545E;
>> + ? arm_linux_record_tdep.ioctl_TIOCSHAYESESP = 0x545F;
>> + ? arm_linux_record_tdep.ioctl_FIOQSIZE = 0x5460;
>> +
>> + ? /* These values are the second argument of system call "sys_fcntl"
>> + ? ? ?and "sys_fcntl64". ?They are obtained from Linux Kernel source. ?*/
>> + ? arm_linux_record_tdep.fcntl_F_GETLK = 5;
>> + ? arm_linux_record_tdep.fcntl_F_GETLK64 = 12;
>> + ? arm_linux_record_tdep.fcntl_F_SETLK64 = 13;
>> + ? arm_linux_record_tdep.fcntl_F_SETLKW64 = 14;
>> +
>> + ? arm_linux_record_tdep.arg1 = ARM_R1_REGNUM;
>> + ? arm_linux_record_tdep.arg2 = ARM_R2_REGNUM;
>> + ? arm_linux_record_tdep.arg3 = ARM_R3_REGNUM;
>> + ? arm_linux_record_tdep.arg4 = ARM_R4_REGNUM;
>> ?}
>>
>> ?/* Provide a prototype to silence -Wmissing-prototypes. ?*/
>> diff -urN orig/arm-tdep.c new/arm-tdep.c
>> --- orig/arm-tdep.c ? ? 2012-05-19 02:32:48.000000000 +0530
>> +++ new/arm-tdep.c ? ? ?2012-06-07 22:36:33.376647300 +0530
>> @@ -11809,7 +11809,7 @@
>> ?{
>> ? struct gdbarch_tdep *tdep = gdbarch_tdep (arm_insn_r->gdbarch);
>> ? struct regcache *reg_cache = arm_insn_r->regcache;
>> - ?uint32_t ret = 0; /* function return value: -1:record failure ;
>> 0:success ?*/
>> + ?uint32_t ret = -1; /* function return value: -1:record failure ;
>> 0:success ?*/
>>
>> ? /* Handle SWI insn; system call would be handled over here. ?*/
>>
>> @@ -11828,6 +11828,7 @@
>> ? ? ? }
>> ? }
>>
>> + ?if (ret)
>> ? printf_unfiltered (_("Process record does not support instruction "
>> ? ? ? ? ? ? ? ? ? ? ? ? "0x%0x at address %s.\n"),arm_insn_r->arm_insn,
>> ? ? ? ? ? ? ? ? ? ? ? ? paddress (arm_insn_r->gdbarch, arm_insn_r->this_addr));