This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Fix "ambiguous linespec" regression: break lineno


>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> I have some draft patch almost without regressions but those two
Jan> locations had some logic.  "break" should put breakpoint to the
Jan> current frame and not to some last arbitrary line listed.

Ok, I see.

>> I realize you're just reverting a bit of code - but is that ObjC hack
>> really needed?  I'd like us to get away from this kind of thing.

Jan> It needs to detect the pattern ^[+-] (for 'break +5', 'break -3'
Jan> etc.) but it should not get confused by the ObjC breakpoints for
Jan> -[func] or +[func].

Jan> I agree if the two locations get unified it is no longer needed.

I wonder if it would be cleaner as a flag to linespec.
That's just speculation, please don't consider it an objection.
I think you can go ahead as you like.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]