This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 03/10] C language


Sergio> +#define	yyparse	_c_parse

It is pedantically better to avoid names with a leading underscore.
While it probably will never cause any problem in practice, I think it
is also just as easy to pick pedantically-correct names at the outset.

So, could you rename these to $LANG_parse_internal or something like that?

Sergio> -  result = yyparse ();
Sergio> +  result = _c_parse ();

I think you don't need to change this line.

>From a spot check it appears these comments apply to all the other yacc
parsers in the series.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]