This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC - Python Scripting] Add 'end' attribute to gdb.Symtab_and_line


ping!

On Mon, May 21, 2012 at 2:10 PM, Siva Chandra <sivachandra@google.com> wrote:
> Attached is a patch which adds the 'end' attribute to
> gdb.Symtab_and_line. ?Essentially, it exposes the 'end' field of
> 'struct symtab_and_line'.
>
> Though I have named the new attribute 'end' in the attached patch, I
> would like to discuss this. ?There is already an attribute 'pc' which
> is described as "Indicates the current program counter address" in the
> documentation. ?I do not think this description is accurate: 'pc' is
> actually the begin address of the program counter address range for
> the current source line. ?To indicate the right meaning of 'pc' and
> the new 'end' attribute, should they be named 'start_pc' and 'end_pc'
> respectively, at least in the python API?
>
> 2012-05-21 ?Siva Chandra Reddy ?<sivachandra@google.com>
>
> ? ? ? ?New attribute 'end' for gdb.Symtab_and_line.
> ? ? ? ?* NEWS (Python Scripting): Add entry about the new attribute.
> ? ? ? ?* python/py-symtab.c (salpy_get_end): New function which
> ? ? ? ?implements the get method for the 'end' attribute of
> ? ? ? ?gdb.Symtab_and_line.
> ? ? ? ?(sal_object_getset): Add entry for the 'end' attribute.
>
> ? ? ? ?doc/
> ? ? ? ?* gdb.texinfo (Symbol Tables In Python): Add description about
> ? ? ? ?the new 'end' attribute of gdb.Symtab_and line.
>
> ? ? ? ?testsuite/
> ? ? ? ?* gdb.python/py-symtab.exp: Add tests to test the new
> attribute
> ? ? ? ?'end' of gdb.Symtab_and_line.
> ? ? ? ?* gdb.python/py-symbol.c: Move break point comment to enable
> ? ? ? ?testing of gdb.Symtab_and_line.end.
>
> Thanks,
> Siva Chandra


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]