Re: [RFA] Add scripts to generate ARI web pages to gdb/contrib/ari directory

[Pedro Alves <palves at redhat dot com>]

On 05/18/2012 11:40 PM, Pierre Muller wrote:

>   Here is a RFA for inclusion of scripts to gdb/contrib/ari.
> 
>   The only changes to RFC-v2 are:
> 1) directory moved from gdb/ari to gdb/contrib./ari
> 2) create-web-ari-in-src.sh adapted to new directory
> 3) This script now output that location of the generated
> web page (with a different message depending on
> the existence of this file).


I really don't like the send_email thing.

> +    if [ "$send_email" == "true" ]; then
> +      if [ "${node}" = "sourceware.org" ]; then
> +	warning_email=gdb-patches@sourceware.org
> +      else
> +        # Use default email
> +	warning_email=${USER}@${node}
> +      fi

If the script really needs to know to send email, and where to send
it to, it'd be much much better to specify the destination with a
command line option.

As Joel said, we don't have to use the new gdb/ari scripts from ss
immediately. We can keep using the ones in ss until the gdb ones
are in shape.

Even sending unexpected email to ${USER}@${node} may not be a
good idea.  I'd vote for leaving the email sending off by default
until we have a command line option.

Other than that, it doesn't seem to cause anyone trouble to put
this stuff in, and work on top.

-- 
Pedro Alves