This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[RFA-v3/ARI fix] Remove use of abort function in common/buffer.c
- From: "Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>
- To: "'Pedro Alves'" <palves at redhat dot com>, <gdb-patches at sourceware dot org>
- Date: Tue, 22 May 2012 17:14:56 +0200
- Subject: [RFA-v3/ARI fix] Remove use of abort function in common/buffer.c
- References: <4fbb59b7.44e2440a.48c4.ffffab13SMTPIN_ADDED@mx.google.com> <4FBB5D9B.5070202@redhat.com> <000c01cd3813$32090b40$961b21c0$@muller@ics-cnrs.unistra.fr> <20120522121832.GC5492@adacore.com> <4FBB88C5.6070900@redhat.com>
> Fine with me, but I'd suggest to just say nothing. The whole point of the
> xrealloc,
> xmalloc, etc. functions is to abort on failure instead of returning NULL.
> We have
> about 150 or so xrealloc calls in the tree, about 70 xcalloc calls, and
> about 700 xmalloc calls. We don't put just comment on most (any?) of
those,
> and
> I don't see what makes this particular instance special.
You are right,
OK for that even simpler patch?
2012-05-22 Pierre Muller <muller@ics.u-strasbg.fr>
* common/buffer.c (buffer_grow): ARI fix: Remove unneeded
call to abort.
Index: common/buffer.c
===================================================================
RCS file: /cvs/src/src/gdb/common/buffer.c,v
retrieving revision 1.3
diff -u -p -r1.3 buffer.c
--- common/buffer.c 11 May 2012 22:24:22 -0000 1.3
+++ common/buffer.c 22 May 2012 15:13:24 -0000
@@ -47,8 +47,6 @@ buffer_grow (struct buffer *buffer, cons
while (buffer->used_size + size > new_buffer_size)
new_buffer_size *= 2;
new_buffer = xrealloc (buffer->buffer, new_buffer_size);
- if (!new_buffer)
- abort ();
memcpy (new_buffer + buffer->used_size, data, size);
buffer->buffer = new_buffer;
buffer->buffer_size = new_buffer_size;