This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[committed]: [PATCH] Check style of mark up and comment
On 04/26/2012 11:56 PM, Tom Tromey wrote:
> Should 'error' be there as well?
>
> Yao> + ;; A space shoud follow "/*", otherwise report a warning.
>
> Typo: "should".
>
Fixed.
> This patch is ok with the typo fix. It is also ok if you want to add
> "error", up to you.
This version checks mark up after "warning" and "error". This is what
I committed. Thanks for the review.
http://sourceware.org/ml/gdb-cvs/2012-04/msg00241.html
--
Yao (éå)
gdb:
2012-04-29 Yao Qi <yao@codesourcery.com>
* gdb-code-style.el: New hook gdb-markup-hook
and gdb-comment-hook.
---
gdb/gdb-code-style.el | 31 ++++++++++++++++++++++++++++++-
1 files changed, 30 insertions(+), 1 deletions(-)
diff --git a/gdb/gdb-code-style.el b/gdb/gdb-code-style.el
index 5897831..28028e6 100644
--- a/gdb/gdb-code-style.el
+++ b/gdb/gdb-code-style.el
@@ -45,4 +45,33 @@
(add-hook 'c-mode-common-hook 'gdb-include-hook)
-;;; gdb-code-style.el ends here
\ No newline at end of file
+;; Check marker up. If the marker up is missing, like,
+;; warning ("abc");
+;; The '(' and '"' will be highlight.
+(defun gdb-markup-hook ()
+ (font-lock-add-keywords
+ nil
+ '(("\\<\\(warning\\|error\\)[ ]*\\(\([^_]\\)" 2 font-lock-warning-face t))))
+
+(add-hook 'c-mode-common-hook 'gdb-markup-hook)
+
+(defun gdb-comment-hook ()
+ ;; A space should follow "/*", otherwise report a warning.
+ ;; If the comment is like:
+ ;; /*F. */
+ ;; The 'F' will be highlight.
+ (font-lock-add-keywords
+ nil
+ '(("/\\*\\([^ ]\\).*\\*/" 1 font-lock-warning-face t)))
+ ;; Two spaces are needed between "." and "*/". Report warning if there
+ ;; is no space (".*/") or only one space (". */").
+ ;; If the comment is like:
+ ;; /* ABC. */ or /* ABC.*/
+ ;; the '.' is highlight.
+ (font-lock-add-keywords
+ nil
+ '(("\\<[[:ascii:]]*\\(\\.[ ]?\\)\\*/" 1 font-lock-warning-face t)))
+ )
+(add-hook 'c-mode-common-hook 'gdb-comment-hook)
+
+;;; gdb-code-style.el ends here
--
1.7.0.4