This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Unbreak program transformation name `configure' options


On 04/27/2012 04:15 PM, Maciej W. Rozycki wrote:

> Hi,
> 
>  This commit:
> 
> 2012-04-19  Pedro Alves  <palves@redhat.com>
> 
> 	gdb/
> 	* configure.ac: Remove gl_EARLY, gl_INIT and AM_INIT_AUTOMAKE
> 	calls.  Configure gnulib using ACX_CONFIGURE_DIR.
> 
> removed the handling of the program transformation name `configure' 
> options in this subdirectory (that was pulled implicitly with 
> AM_INIT_AUTOMAKE).
> 
>  OK to check in the following fix that reinstates it?


Yes, thanks.

I should have remembered to look at 9c9eabcbe003d635d12d43b5a926d7c01c2f5928 ,
the patch that originally added gnulib.

2008-04-14  Daniel Jacobowitz  <dan@codesourcery.com>

        * Makefile.in (LIBGNU, INCGNU): Define.
        (INTERNAL_CFLAGS_BASE): Add INCGNU.
        (INTERNAL_LIBS, CLIBS, CDEPS): Add LIBGNU.
        (CLEANDIRS): New.
        ($(LIBGNU), all-lib): New rules.
        (clean, distclean, do-maintainer-clean): Use CLEANDIRS.
        * configure.ac: Use gl_EARLY, gl_INIT, and AM_INIT_AUTOMAKE.
        Simplify AC_CONFIG_AUX_DIR.  Generate gnulib/Makefile.
        * gnulib: New directory, from gnulib-tool.
        * configure, aclocal.m4: Regenerated.

It indeed removed AC_ARG_PROGRAM.  It also does this though:

-AC_CONFIG_AUX_DIR(`cd $srcdir;pwd`/..)
+AC_CONFIG_AUX_DIR(..)

I wonder if we need to restore that bit as well.

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]